[Mlir-commits] [mlir] [MLIR] Change name and description of `mlir-print-assume-verified` to be more explicit. (PR #184812)

[llvmlistbot at llvm.org]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir

Author: Arjun Bhamra (abhamra)

<details>
<summary>Changes</summary>

Per https://github.com/llvm/llvm-project/issues/128346#issuecomment-4004154144, we change the name of the `mlir-print-assume-verified` pass to be `mlir-unsafe-print-assume-verified` so that it is more clear that unsafe behavior such as crashing may be expected. 

We also update the description to the same effect, although this may not be necessary.

cc: @<!-- -->joker-eph 

---
Full diff: https://github.com/llvm/llvm-project/pull/184812.diff


1 Files Affected:

- (modified) mlir/lib/IR/AsmPrinter.cpp (+3-2) 


``````````diff
diff --git a/mlir/lib/IR/AsmPrinter.cpp b/mlir/lib/IR/AsmPrinter.cpp
index b3242f838fc1d..8d195932daa90 100644
--- a/mlir/lib/IR/AsmPrinter.cpp
+++ b/mlir/lib/IR/AsmPrinter.cpp
@@ -175,8 +175,9 @@ struct AsmPrinterOptions {
       llvm::cl::desc("Print the generic op form"), llvm::cl::Hidden};
 
   llvm::cl::opt<bool> assumeVerifiedOpt{
-      "mlir-print-assume-verified", llvm::cl::init(false),
-      llvm::cl::desc("Skip op verification when using custom printers"),
+      "mlir-unsafe-print-assume-verified", llvm::cl::init(false),
+      llvm::cl::desc(
+          "Skip op verification when using custom printers; crashes expected."),
       llvm::cl::Hidden};
 
   llvm::cl::opt<bool> printLocalScopeOpt{

``````````

</details>


https://github.com/llvm/llvm-project/pull/184812