[Mlir-commits] [mlir] [mlir][vector] Replace OneDimMultiReductionToTwoDim with OneDimMultiReductionToReduction (PR #184241)

[Andrzej Warzyński]

================
@@ -223,18 +223,17 @@ def ApplyMaterializeMasksPatternsOp : Op<Transform_Dialect,
   let assemblyFormat = "attr-dict";
 }
 
-def ApplyReorderAndExpandMultiReductionPatternsOp: Op<Transform_Dialect,
-    "apply_patterns.vector.reorder_and_expand_multi_reduction_dims",
+def ApplyReorderMultiReductionPatternsOp: Op<Transform_Dialect,
+    "apply_patterns.vector.reorder_multi_reduction_dims",
     [DeclareOpInterfaceMethods<PatternDescriptorOpInterface>]> {
   let description = [{
     Indicates that vector multi_reduction-like operations should be
     transformed such that all reduction dimensions become innermost or
     outermost, and 1-D reductions are lifted to 2-D.
----------------
banach-space wrote:

```suggestion
Indicates that vector multi_reduction-like operations should be
transformed such that all reduction dimensions become innermost or
outermost, depending on `lowereing_strategy`.
```

This makes me think that `lowering_strategy` is yet another misnomer here.

https://github.com/llvm/llvm-project/pull/184241