[Mlir-commits] [mlir] [mlir][vector] Replace OneDimMultiReductionToTwoDim with OneDimMultiReductionToReduction (PR #184241)
Andrzej WarzyĆski
llvmlistbot at llvm.org
Tue Mar 3 12:16:03 PST 2026
================
@@ -375,7 +375,7 @@ struct TwoDimMultiReductionToElementWise
}
};
-/// Lowers 2D vector.multi_reduction to a squence of vector.reduction Ops
+/// Lowers 2D vector.multi_reduction to a sequence of vector.reduction ops.
----------------
banach-space wrote:
That pattern above uses this format (note `Arith Ops` rather than `Arith ops.`):
```cpp
/// Lowers 2D vector.multi_reduction to a squence of Arith Ops
```
I don't mind what we use, but we should be using one style consistently. Btw, thanks for fixing the typo!
https://github.com/llvm/llvm-project/pull/184241
More information about the Mlir-commits
mailing list