[Mlir-commits] [mlir] [mlir][linalg] Expose data layout propagation patterns via transform op (PR #184151)

[Andrzej Warzyński]

================

----------------
banach-space wrote:

> Unfortunately, -test-linalg-data-layout-propagation pulls in more patterns and not all checks can pass with this transform alone.

Do you mean `populateExtractSliceSinkingPatterns`?

https://github.com/llvm/llvm-project/blob/ae363d50ad292b4d8c33bf795ad16c79eb640b19/mlir/test/lib/Dialect/Linalg/TestDataLayoutPropagation.cpp?plain=1#L44

You could add a TD Op for that as well. 

Also, `test-linalg-data-layout-propagation` should match `transform.apply_patterns.linalg.data_layout_propagation `. If it doesn't we should rename things.

... The easiest thing could be:
* move `PushDownExtractSliceOpThroughGenericOp` to `populateDataLayoutPropagationPatterns`
* delete `populateExtractSliceSinkingPatterns`.

Would that work for you?

https://github.com/llvm/llvm-project/pull/184151