[Mlir-commits] [mlir] [mlir] Add `areLoopIterArgTypesCompatible` to `LoopLikeOpInterface` (PR #184116)

[Hocky Yudhiono]

================
@@ -77,37 +77,35 @@ LogicalResult detail::verifyLoopLikeOpInterface(Operation *op) {
            << " != " << loopLikeOp.getRegionIterArgs().size();
 
   // Verify types of inits/iter_args/yielded values/loop results.
-  int64_t i = 0;
   auto yieldedValues = loopLikeOp.getYieldedValues();
   for (const auto [index, init, regionIterArg] :
        llvm::enumerate(loopLikeOp.getInits(), loopLikeOp.getRegionIterArgs())) {
-    if (init.getType() != regionIterArg.getType())
+    if (!loopLikeOp.areLoopIterArgTypesCompatible(init.getType(),
+                                                  regionIterArg.getType()))
       return op->emitOpError(std::to_string(index))
              << "-th init and " << index
              << "-th region iter_arg have different type: " << init.getType()
              << " != " << regionIterArg.getType();
     if (!yieldedValues.empty()) {
----------------
hockyy wrote:

Oh, I see, then why don't we just merge it together with the next loop where 
```
if (loopLikeOp.getLoopResults()) {
```
is true?

https://github.com/llvm/llvm-project/pull/184116