[Mlir-commits] [mlir] [mlir] Add `areLoopIterArgTypesCompatible` to `LoopLikeOpInterface` (PR #184116)

[Oleksandr Alex Zinenko]

================
@@ -77,37 +77,35 @@ LogicalResult detail::verifyLoopLikeOpInterface(Operation *op) {
            << " != " << loopLikeOp.getRegionIterArgs().size();
 
   // Verify types of inits/iter_args/yielded values/loop results.
-  int64_t i = 0;
   auto yieldedValues = loopLikeOp.getYieldedValues();
   for (const auto [index, init, regionIterArg] :
        llvm::enumerate(loopLikeOp.getInits(), loopLikeOp.getRegionIterArgs())) {
-    if (init.getType() != regionIterArg.getType())
+    if (!loopLikeOp.areLoopIterArgTypesCompatible(init.getType(),
+                                                  regionIterArg.getType()))
       return op->emitOpError(std::to_string(index))
              << "-th init and " << index
              << "-th region iter_arg have different type: " << init.getType()
              << " != " << regionIterArg.getType();
     if (!yieldedValues.empty()) {
-      if (regionIterArg.getType() != yieldedValues[index].getType())
+      if (!loopLikeOp.areLoopIterArgTypesCompatible(
+              regionIterArg.getType(), yieldedValues[index].getType()))
         return op->emitOpError(std::to_string(index))
                << "-th region iter_arg and " << index
                << "-th yielded value have different type: "
                << regionIterArg.getType()
                << " != " << yieldedValues[index].getType();
     }
-    ++i;
   }
-  i = 0;
   if (loopLikeOp.getLoopResults()) {
-    for (const auto it : llvm::zip_equal(loopLikeOp.getRegionIterArgs(),
-                                         *loopLikeOp.getLoopResults())) {
-      if (std::get<0>(it).getType() != std::get<1>(it).getType())
-        return op->emitOpError(std::to_string(i))
-               << "-th region iter_arg and " << i
+    for (const auto [index, regionIterArg, loopResult] : llvm::enumerate(
+             loopLikeOp.getRegionIterArgs(), *loopLikeOp.getLoopResults())) {
+      if (!loopLikeOp.areLoopIterArgTypesCompatible(regionIterArg.getType(),
+                                                    loopResult.getType()))
+        return op->emitOpError(std::to_string(index))
+               << "-th region iter_arg and " << index
----------------
ftynse wrote:

I randomly learned about `llvm::getOrdinalSuffix`. Not necessary to fix in this commit since this is not directly related, but now you know, too :)

https://github.com/llvm/llvm-project/pull/184116