[Mlir-commits] [mlir] [mlir] Add `areLoopIterArgTypesCompatible` to `LoopLikeOpInterface` (PR #184116)
Oleksandr Alex Zinenko
llvmlistbot at llvm.org
Mon Mar 2 06:35:28 PST 2026
https://github.com/ftynse approved this pull request.
Looks reasonable to me. The interface is primarily for LICM, so hoisting operations and removing iterargs/yielded values. It may be worth documenting that it doesn't guarantee exact type match in case somebody assumed that.
On a side note, I didn't check if there are cases where this would not hold, but it may make sense to defer the type compatibility check to `RegionBranchOpInterface` and/or perhaps have `LoopLikeOpInterface` inherit from that. Not for here, I suspect fun around `scf.forall.
https://github.com/llvm/llvm-project/pull/184116
More information about the Mlir-commits
mailing list