[Mlir-commits] [mlir] [mlir][ABI] Fix scalable vector mapping in ABITypeMapper (PR #206617)

[Andrzej Warzyński]

================
@@ -70,12 +70,20 @@ const llvm::abi::Type *ABITypeMapper::mapVectorType(mlir::VectorType type) {
   if (!elementTy)
     return nullptr;
 
+  // ABI lowering cannot represent vectors with more than one scalable
+  // dimension (e.g. vector<[2]x[4]xf32>) since ElementCount only has a
+  // single scalable bit and would silently produce vscale*N instead of
+  // the correct vscale^2*N.
----------------
banach-space wrote:

See my comment elsewhere - I would refrain from `vscale^2` - we have never really defined what that means.

https://github.com/llvm/llvm-project/pull/206617