[Mlir-commits] [mlir] [mlir][tosa] fallback unknown type (PR #205873)

[Luke Hutton]

https://github.com/lhutton1 requested changes to this pull request.

Hi @mygitljf, thanks for the change!

This part of the validation pass works on the assumption that it is operating on TOSA supported types, but `f64` is not, hence the crash observed here. It's odd that this didn't get picked up by [isValidElementType](https://github.com/llvm/llvm-project/blob/0c6a0c4ccf234c5d9969294b454cb615277ede14/mlir/lib/Dialect/Tosa/Transforms/TosaValidation.cpp#L1471) which checks operand/result types [here](https://github.com/llvm/llvm-project/blob/0c6a0c4ccf234c5d9969294b454cb615277ede14/mlir/lib/Dialect/Tosa/Transforms/TosaValidation.cpp#L1535). I wonder if this logic needs to be changed to make sure the types of variable operations are also checked?

https://github.com/llvm/llvm-project/pull/205873