[Mlir-commits] [mlir] [mlir][llvmir] Add new support for strict fp handling (PR #205158)

[Tobias Gysi]

gysit wrote:

> @gysit @kuhar The fenv attribute I have here is a bit aspirational. It's where I'd like to end up after the corresponding LLVM IR support is implemented. However, there's currently no way to represent static rounding mode in LLVM IR, so I'm inclined to remove that for now. Will that cause backward compatibility issues if we want to add it in the future?

At least in the textual IR, OptionalParameter and DefaultValuedParameter should give some degree of backward compatibility in the sense that you can read a struct that has been emitted before the field existed. Bytecode has some mechanism for backward compatibility AFAIK but I am not an expert there. 

It may also make sense to already specify the field and fail in the lowering if a specific option is unsupported. I am not sure if there is precedence for something like this in one of the Arith lowerings. 


https://github.com/llvm/llvm-project/pull/205158