[Mlir-commits] [mlir] [mlir][linalg/scf/transform] scalable tiling and fusion for pack/unpack ops (PR #204007)

[Andrzej Warzyński]

https://github.com/banach-space commented:

Thank you, Ege - overall this makes sense to me!

We have been discussing various approaches to resolving #150185 for quite a while, and this feels like a good compromise. Ultimately, the root cause of the issues we have been hitting is the special nature of `linalg.pack` and `linalg.unpack`, and the fact that these ops define their own tile sizes. We are effectively missing a mechanism to relate those tile sizes to the "SCF tiling" tile sizes, and this seems like a solid solution.

I am submitting comments on the first commit now. I will start reading the second commit shortly.

Note to other reviewers: the overall design makes sense to me, and I expect to approve this PR once I have reviewed all 4 commits. If you have design-level objections, please raise them early.

https://github.com/llvm/llvm-project/pull/204007