[Mlir-commits] [mlir] [mlir][llvmir] Add new support for strict fp handling (PR #205158)

[Tobias Gysi]

https://github.com/gysit commented:

Thanks for working on this!

I believe this deserves an RFC on the LLVM/MLIR discourse since it is quite an intrusive change.

To make sure I understand correctly. Does this PR prefetch upcoming changes in LLVM proper? If so, that would contradict the core rationale of the MLIR LLVM dialect, which is meant to closely mirror LLVM IR as it exists today.

Additionally, the translation layer to LLVM IR is already quite complex. Adding extra legalization logic there further increases complexity. Would it be possible to handle this through a separate, higher-level dialect that models these constraints and then lowers directly to the existing LLVM dialect constraint intrinsics instead? Once LLVM proper implements the changes, we can pull these changes into LLVM dialect.


https://github.com/llvm/llvm-project/pull/205158