[Mlir-commits] [mlir] [mlir][gpu] Avoid duplicate attrs when lowering gpu.func (PR #205035)

[Mehdi Amini]

joker-eph wrote:

> > Your reasoning would apply to MLIR as whole, you seem to imply that any `<dialect>.<name>` discardable attribute that conflict with a `<name>` inherent attribute should be forbidden. I'm not sure I would agree with this though.
> 
> Only if the dialect of the op with inherent attr name collides with the discardable key `<dialect>.<name>`. Otherwise, these kind of errors can keep occurring, it also tells users they are likely making a mistake.

So: to expand on my previous message, this looks to me like a proposal for MLIR as whole and not directly related here.

In this case, the fact that the lowering is trying to propagate `gpu.xxxx` when xxxx is an inherent attribute looks like a bug to me and we should stop doing so.

https://github.com/llvm/llvm-project/pull/205035