[Mlir-commits] [mlir] Allow signless integer element types in vector.step (PR #205142)

[llvmlistbot at llvm.org]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

* 3831 tests passed
* 439 tests skipped
* 1 test failed

## Failed Tests
(click on a test name to see its output)

### MLIR
<details>
<summary>MLIR.Conversion/VectorToSPIRV/vector-to-spirv.mlir</summary>

```
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
c:\_work\llvm-project\llvm-project\build\bin\mlir-opt.exe -split-input-file -convert-vector-to-spirv -verify-diagnostics C:\_work\llvm-project\llvm-project\mlir\test\Conversion\VectorToSPIRV\vector-to-spirv.mlir -o - | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe C:\_work\llvm-project\llvm-project\mlir\test\Conversion\VectorToSPIRV\vector-to-spirv.mlir
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\mlir-opt.exe' -split-input-file -convert-vector-to-spirv -verify-diagnostics 'C:\_work\llvm-project\llvm-project\mlir\test\Conversion\VectorToSPIRV\vector-to-spirv.mlir' -o -
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' 'C:\_work\llvm-project\llvm-project\mlir\test\Conversion\VectorToSPIRV\vector-to-spirv.mlir'
# .---command stderr------------
# | C:\_work\llvm-project\llvm-project\mlir\test\Conversion\VectorToSPIRV\vector-to-spirv.mlir:1098:11: error: CHECK: expected string not found in input
# | // CHECK: spirv.Constant 0 : i8
# |           ^
# | <stdin>:841:31: note: scanning from here
# |  func.func @step_i8_overflow() -> vector<257xi8> {
# |                               ^
# | <stdin>:848:20: note: possible intended match here
# | module attributes {spirv.target_env = #spirv.target_env<#spirv.vce<v1.0, [Int16, Shader], []>, #spirv.resource_limits<>>} {
# |                    ^
# | 
# | Input file: <stdin>
# | Check file: C:\_work\llvm-project\llvm-project\mlir\test\Conversion\VectorToSPIRV\vector-to-spirv.mlir
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# |               .
# |               .
# |               .
# |             836:  } 
# |             837: } 
# |             838:  
# |             839: // ----- 
# |             840: module attributes {spirv.target_env = #spirv.target_env<#spirv.vce<v1.0, [Int8, Shader], []>, #spirv.resource_limits<>>} { 
# |             841:  func.func @step_i8_overflow() -> vector<257xi8> { 
# | check:1098'0                                   X~~~~~~~~~~~~~~~~~~~~ error: no match found
# |             842:  %0 = vector.step : vector<257xi8> 
# | check:1098'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |             843:  return %0 : vector<257xi8> 
# | check:1098'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |             844:  } 
# | check:1098'0     ~~~
# |             845: } 
# | check:1098'0     ~~
# |             846:  
# | check:1098'0     ~
# |             847: // ----- 
# | check:1098'0     ~~~~~~~~~
# |             848: module attributes {spirv.target_env = #spirv.target_env<#spirv.vce<v1.0, [Int16, Shader], []>, #spirv.resource_limits<>>} { 
# | check:1098'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# | check:1098'1                        ?                                                                                                         possible intended match
# |             849:  func.func @step_size1_i16() -> vector<1xi16> { 
# | check:1098'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |             850:  %cst0_i16 = spirv.Constant 0 : i16 
# |             851:  %0 = builtin.unrealized_conversion_cast %cst0_i16 : i16 to vector<1xi16> 
# |             852:  return %0 : vector<1xi16> 
# |             853:  } 
# |               .
# |               .
# |               .
# | >>>>>>
# `-----------------------------
# error: command failed with exit status: 1

--

```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/205142