[Mlir-commits] [mlir] [mlir][arith] Fix issue where setOperand is called inside the fold fu… (PR #204506)

[Mehdi Amini]

joker-eph wrote:

> That said, I still don't fully understand the rationale behind this design. What is the distinction between a folder and a canonicalization pattern now? Is a folder essentially just a canonicalization pattern that is restricted to modifying only the current operation?

Folders can't create IR, see the documentation: https://mlir.llvm.org/docs/Canonicalization/#canonicalizing-with-the-fold-method

https://github.com/llvm/llvm-project/pull/204506