[Mlir-commits] [mlir] [mlir][VectorToLLVM] add opt-in `enable-gep-inbounds-nuw` pass flag for `vector.load/store` (PR #202118)

[Andrzej Warzyński]

banach-space wrote:

> Silly question: is it correct for load and store to behave with different semantics depending on the dialect? 

That's a very good question! Yes, that would be totally valid, provided it's intentional rather than accidental :)

> I'd rather open a discussion on the Discourse (and possibly an issue addressing that, if it's good practice).

👍🏻 

> 
> The correct question to ask is:
> 
> * _"Is the current behavior of load/store in different dialects correct?"_

Yes, provided there's a reason for that.

> * _"Do we want to align all load/store semantics?"_

Consistency is highly valued, yes. However, within reason - there's no point forcing everything to behave identically if there are good reasons not to.

Hopefully this makes sense :)

https://github.com/llvm/llvm-project/pull/202118