[Mlir-commits] [mlir] [mlir][vector] reject negative strides for `vector.load`/`vector.store` (PR #204611)

[Federico Bruzzone]

FedericoBruzzone wrote:

> LGTM % nits
> 
> Btw, note https://llvm.org/docs/GitHub.html#landing-your-change, especially this part:
> 
> > The LLVM Project monorepo on GitHub is configured to always use “Squash and Merge” as the pull request merge option when using the web interface. With this option, GitHub uses the PR summary as the default commit message.
> > Users with write access who can merge PRs have a final opportunity to **edit the commit title and message before merging**. However, this option is not available to contributors without write access.
> 
> Mindful of that, please make sure that the summary focused on the current PR - everything else should be a comment. In particular, the section that starts with this sentence is a side comment and should be moved (e.g. as a comment below the summary):
> 
> > Please consider to read the following 🫶
> > ...
> 
> Thanks!

While I'm aware of the "edit the commit title and message before merging," I wasn't aware of this detail (though it makes perfect sense). Thanks for pointing it out :D

https://github.com/llvm/llvm-project/pull/204611