[Mlir-commits] [clang] [llvm] [mlir] [IR] Explicitly specify target feature for module asm (PR #204548)

[Nikita Popov]

nikic wrote:

> I built this branch and checked the behavior of the [test I added here](https://github.com/llvm/llvm-project/pull/97685/changes#diff-84fb36bd815b53b5abd6e2a1485c438c09f628ad8b4886469cb1125fa464e859) in the "stopgap" PR (#97685) for addressing this, but that test still fails on this branch, just as it does on `main`. Is that expected with this approach?

Yes, because your test uses an LLVM IR input that does not specify target features. If you start from a C test case (e.g. the one in https://github.com/llvm/llvm-project/issues/61991) it works fine.

https://github.com/llvm/llvm-project/pull/204548