[Mlir-commits] [llvm] [mlir] [mlir][emitc] Ensure memref-to-emitc applies type converter to memref element types (PR #203742)

[Jeremy Kun]

================
@@ -0,0 +1,32 @@
+// RUN: mlir-opt -convert-to-emitc -split-input-file %s | FileCheck %s
----------------
j2kun wrote:

> since this patch enables the conversion via the full EmitC conversion pipeline, instead of the narrow memref-to-emitc path mentioned

As far as I can tell, there is no way to test the functionality using only `-convert-memref-to-emitc`. This is because the full `-convert-to-emitc` pipeline is what registers the custom type converter in the Test dialect. It doesn't really seem worth it to add a special pass just for the test dialect that duplicates the `-convert-to-emitc` registration logic, and it seems like the intended interface is `-convert-to-emitc`, not to run the individual passes in sequence.

I updated the PR message with the following clarification:

> It is worth noting that, while this patch only affects `-convert-memref-to-emitc`, the change has no impact without the additional type converter registrations in `-convert-to-emitc`.



https://github.com/llvm/llvm-project/pull/203742