[Mlir-commits] [llvm] [mlir] [mlir][emitc] Ensure memref-to-emitc applies type converter to memref element types (PR #203742)

[Andrzej Warzyński]

================
@@ -0,0 +1,32 @@
+// RUN: mlir-opt -convert-to-emitc -split-input-file %s | FileCheck %s
+
+// CHECK-LABEL: emitc.func @test_memref_alloc()
+func.func @test_memref_alloc() {
----------------
banach-space wrote:

[nit] `@test_memref_alloc` is not a very descriptive name (we know that it's a "test" function and that it's testing MemRef without encoding that info in the function name). I suggest trimming to `@alloc`. 

There's (not such a short) guideline on MLIR's preferences here: https://mlir.llvm.org/getting_started/TestingGuide/#test-formatting-best-practices

I have similar comment for the other test.

https://github.com/llvm/llvm-project/pull/203742