[Mlir-commits] [mlir] [mlir][vector] Add opt-in `inbounds`/`nneg` flags to `vector.load`/`vector.store` (PR #202118)

[Federico Bruzzone]

FedericoBruzzone wrote:

> Given the confusion in this PR, I suggest adding an assert in the lowering code to further document the restriction. Leaving this as a TODO for @FedericoBruzzone :)

Thanks! I'll definitely update this, I think this will help in the future!

> Vector dialect does not currently maintain this information. Making lowering rely on such attributes would require auditing and updating the relevant Vector transformations to preserve them correctly. That is a much larger scope than this PR, and I don't think it is reasonable to require it here.
> So I don't think this should block the current approach. If we want MLIR-level attributes to carry this information reliably, that should be done as a separate follow-up effort.

I think the same way too, we can stay like this for now <3

> As in, you are proposing a patch that will update memref.store lowering when strides are negative? SGTM

[This is the PR](https://github.com/llvm/llvm-project/pull/204309). I opened it to keep this one a little lighter :'D


https://github.com/llvm/llvm-project/pull/202118