[Mlir-commits] [mlir] [mlir][OpenMP] Translate task_reduction on omp.taskgroup (PR #199565)

[Sairudra More]

================

----------------
Saieiei wrote:

Thanks, confirmed and fixed @tblah, @MattPD .

The issue was reproducible for non-default address-space reduction storage: the descriptor could receive a non-default-AS original pointer while the init/comb callback ABI remained generic `ptr`.

I updated the descriptor setup to normalize non-default-AS original pointers with an explicit `addrspacecast` before storing them into `kmp_taskred_input_t`, keeping the runtime callback ABI generic/default-AS. This matches the runtime `void *` descriptor/callback shape and leaves the default-AS path unchanged.

I also added a `!llvm.ptr<1>` regression test that checks the `addrspacecast`, descriptor stores, and generic init/comb callback signatures.


https://github.com/llvm/llvm-project/pull/199565