[Mlir-commits] [mlir] [mlir][python] Fix segfault at interpreter shutdown with entered contexts (PR #203826)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Sun Jun 14 22:27:32 PDT 2026
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- mlir/lib/Bindings/Python/IRCore.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/mlir/lib/Bindings/Python/IRCore.cpp b/mlir/lib/Bindings/Python/IRCore.cpp
index e0a141d09..fc69ef888 100644
--- a/mlir/lib/Bindings/Python/IRCore.cpp
+++ b/mlir/lib/Bindings/Python/IRCore.cpp
@@ -5299,10 +5299,8 @@ void populateIRCore(nb::module_ &m) {
// the main thread. When the thread_local vector destructs, its nb::object
// members call Py_DECREF through the dead runtime, causing a segfault.
// Clearing the stack in atexit releases references while alive.
- nb::module_::import_("atexit")
- .attr("register")(nb::cpp_function([]() {
- PyThreadContextEntry::getStack().clear();
- }));
+ nb::module_::import_("atexit").attr("register")(
+ nb::cpp_function([]() { PyThreadContextEntry::getStack().clear(); }));
}
} // namespace MLIR_BINDINGS_PYTHON_DOMAIN
} // namespace python
``````````
</details>
https://github.com/llvm/llvm-project/pull/203826
More information about the Mlir-commits
mailing list