[Mlir-commits] [mlir] [MLIR][EmitC] Mark CastOp as Pure (PR #202749)

[Mehdi Amini]

================

----------------
joker-eph wrote:

Looks fine, but should be in the actual op description: this comment won't be in the generated doc I believe.

There also the `Arg<...>' to describe arguments (like here: https://github.com/llvm/llvm-project/blob/db210c5e33643a8154329a607b5b6dcd419271df/mlir/include/mlir/Dialect/AMDGPU/IR/AMDGPUOps.td#L425 ) but it's more for short description.
Here this affects the operation semantics, hence why it should be in the description.

I would also mention that if `pure` is present and the user-defined conversion isn't, it's would be UB to execute.


https://github.com/llvm/llvm-project/pull/202749