[Mlir-commits] [mlir] [MLIR][XeGPU] Use context-aware type converter in WgToSgDistribute and Blocking pass (PR #194685)

[Charitha Saumya]

charithaintc wrote:

> > > Instead we should fix it on the `getLayout` utility method. if the block is detached (no block arg case), we can simply retrieve the layout from init args of the parent op.
> > 
> > 
> > If there is a way to retrieve, please avoid precomputation and cache. But I am not sure this is the case, or else getDistributeLayoutAttr() already retrieve the layout from init args of parent op for block arguments. @nbpatel
> 
> correct, the problem is not the retrieval, its that the block argument has no reachable parent op when the type converter fires.

still not very clear to me. how come a block arg cannot have a reachable parent op at any point of time? or do you mean to say that now the parent op is not the old one (it's been replaced).

I feel like this is an issue in upstream infra. this issues makes the context aware type conversion very inconvenient to use. We should consider filing an issue to fix this by relevant parties. 

https://github.com/llvm/llvm-project/pull/194685