[Mlir-commits] [mlir] [mlir][LLVM][ROCDL] Add buffer oob mode module flags, flag interfaces (PR #202729)

[Krzysztof Drewniak]

================
@@ -578,7 +577,24 @@ ModuleFlagAttr::verify(function_ref<InFlightDiagnostic()> emitError,
         llvm::all_of(arrayAttr, [](Attribute a) { return isa<StringAttr>(a); }))
       return success();
 
-  return emitError() << "only integer, string, and string-array values are "
-                        "currently supported for unknown key '"
-                     << key << "'";
+  return emitError()
+         << "only integer, integer-like dialect attributes, string, "
+            "and string-array values are currently supported for "
+            "unknown key '"
+         << key << "'";
 }
+
+LogicalResult
+ModuleFlagAttr::verify(function_ref<InFlightDiagnostic()> emitError,
+                       LLVM::ModFlagBehavior flagBehavior, StringAttr key,
+                       Attribute value) {
+  return LLVM::detail::verifyModuleFlagValue(key, value, emitError);
----------------
krzysz00 wrote:

I figure it makes sense to verify these things in isolation since they might be used in other contexts?

https://github.com/llvm/llvm-project/pull/202729