[Mlir-commits] [mlir] [mlir][vector] extend `createReadOrMaskedRead`/`createWriteOrMaskedWrite` with permutation map support (PR #202766)

[Andrzej Warzyński]

================
@@ -434,30 +457,47 @@ Value vector::createReadOrMaskedRead(OpBuilder &builder, Location loc,
   int64_t vecToReadRank = vecToReadTy.getRank();
   auto vecToReadShape = vecToReadTy.getShape();
 
-  assert(sourceShape.size() == static_cast<size_t>(vecToReadRank) &&
-         "expected same ranks.");
+  size_t expectedSourceRank =
+      permutationMap ? permutationMap.getNumDims() : vecToReadRank;
+  assert(sourceShape.size() == expectedSourceRank &&
+         "expected source rank to match permutation map dims or vector rank.");
----------------
banach-space wrote:

Shouldn't `permutationMap.getNumDims() == vecToReadRank`?

https://github.com/llvm/llvm-project/pull/202766