[Mlir-commits] [mlir] [mlir][vector] extend `createReadOrMaskedRead`/`createWriteOrMaskedWrite` with permutation map support (PR #202766)

[Andrzej Warzyński]

================
@@ -224,11 +224,17 @@ bool isLinearizableVector(VectorType type);
 /// `useInBoundsInsteadOfMasking` to `true` to use the "in_bounds" attribute
 /// instead of explicit masks.
 ///
-/// Note: all read offsets are set to 0.
+/// When \p permutationMap is provided the in_bounds attribute is inferred from
+/// it: dimension i is in-bounds when the map result is an AffineDimExpr
+/// pointing to a static memref dimension divisible by the vector size, or an
+/// AffineConstantExpr (broadcast). Custom \p indices must also be supplied in
+/// that case; if \p indices is empty, all offsets default to 0.
----------------
banach-space wrote:

We don't use Doxygen markers in MLIR. 
```suggestion
/// When `permutationMap` is provided the in_bounds attribute is inferred from
/// it: dimension i is in-bounds when the map result is an AffineDimExpr
/// pointing to a static memref dimension divisible by the vector size, or an
/// AffineConstantExpr (broadcast). Custom`indices` must also be supplied in
/// that case; if `indices` is empty, all offsets default to 0.
```

Also, why do we need indices when permutation map is specified?

https://github.com/llvm/llvm-project/pull/202766