[Mlir-commits] [mlir] [mlir] Don't use shared_ptr reference. (PR #202703)
Chris Lattner
llvmlistbot at llvm.org
Tue Jun 9 09:04:30 PDT 2026
https://github.com/lattner approved this pull request.
Awesome, thank you for tracking this down and fixing it. This was a horrific debugging escapade.
Suggestion: change the ctor to take the ref as `std::shared_ptr<llvm::SourceMgr>&&` instead of `const std::shared_ptr<llvm::SourceMgr>&`. so the caller can transfer in ownership?
https://github.com/llvm/llvm-project/pull/202703
More information about the Mlir-commits
mailing list