[Mlir-commits] [mlir] [MLGO][EmitC] Scalarize single-element tensor returns (PR #199686)

[Andrzej Warzyński]

================

----------------
banach-space wrote:

>From what I can tell, this block does one thing:
* Updates the return statement.

However, from your comment:
>   // Extract the unique element before each return, update the function type,
>  // and fix direct call users that were recorded during analysis.

To me, "extracting" is just a "by-product" of "scalarising" the return stmt, but it's **scalarisation** that's the main thing. [nit] I would rephrase a bit.

Also, the function type is not updated until after this block of code. I suggest moving the comment regarding the function type closer to the code that does that ;-)

https://github.com/llvm/llvm-project/pull/199686