[Mlir-commits] [mlir] [mlir][Func][EmitC] Bail-out to avoid errors from MemRef array conversions (PR #198583)

[Andrzej Warzyński]

banach-space wrote:

> > Nice, thank you for refactoring the tests two use -convert-{dialect}-to-emitc rather than the -convert-to-emitc mammoth :)
> 
> Mmmm why?

With `-convert-{dialect}-to-emitc`, we know exactly what we are testing. With, `-convert-to-emitc`, you pull in many other things along the way and you may end-up testing something else that's not relevant (e.g. `-convert-emitc-to-emitc` mixed with `-convert-arith-to-emitc` instead of `-convert-emitc-to-emitc` alone).

> Taking the direction for LLVM, I've been trying instead to killl these redundant path to align on the single `convert-to-llvm` path and ensure we don't have subtle differences between these.

It's not clear to me what path EmitC prefers to follow , but given that this PR is _extending pre-existing test files_  (as opposed to creating new ones), it felt safe to assume that this is the expected direction. CC @aniragil + @marbre 

https://github.com/llvm/llvm-project/pull/198583