[Mlir-commits] [mlir] [mlir][Shard] Propagate failures in ConvertShardToMPI (PR #211713)
Maksim Levental
llvmlistbot at llvm.org
Fri Jul 31 18:58:02 PDT 2026
================
@@ -1212,13 +1212,18 @@ struct ConvertShardToMPIPass
populateCallOpTypeConversionPattern(patterns, typeConverter);
populateReturnOpTypeConversionPattern(patterns, typeConverter);
- (void)applyPartialConversion(getOperation(), target, std::move(patterns));
+ if (failed(applyPartialConversion(getOperation(), target,
+ std::move(patterns)))) {
+ signalPassFailure();
+ return;
+ }
----------------
makslevental wrote:
nit
```suggestion
if (failed(applyPartialConversion(getOperation(), target,
std::move(patterns)))) {
return signalPassFailure();
}
```
(`signalPassFailure` returns `void` already)
https://github.com/llvm/llvm-project/pull/211713
More information about the Mlir-commits
mailing list