[Mlir-commits] [mlir] [mlir][affine] Treat failed dependence checks conservatively (PR #211014)

[Oleksandr Alex Zinenko]

================
@@ -719,9 +719,12 @@ void mlir::affine::getDependenceComponents(
         DependenceResult result = checkMemrefAccessDependence(
             srcAccess, dstAccess, d, /*dependenceConstraints=*/nullptr,
             &depComps);
+        if (result.value == DependenceResult::Failure)
+          return failure();
         if (hasDependence(result))
----------------
ftynse wrote:

This function looks dangerous as it is, can we either (a) rename this to `mustHaveDependence` and introduce a `mayHaveDependence` that conservatively returns true if failed to analyze or (b) make it assert that result != Failure?

https://github.com/llvm/llvm-project/pull/211014