[Mlir-commits] [mlir] [mlir][SPIRV] Diagnose missing return value (PR #210566)

[llvmlistbot at llvm.org]

https://github.com/qyingwu updated https://github.com/llvm/llvm-project/pull/210566

>From 8d558af4b5334474b52fa60002ce5e521e786b88 Mon Sep 17 00:00:00 2001
From: qyingwu <qiyingwu at utexas.edu>
Date: Sat, 18 Jul 2026 19:10:29 -0700
Subject: [PATCH] [mlir][SPIRV] Diagnose missing return value

---
 mlir/lib/Dialect/SPIRV/IR/SPIRVOps.cpp        |  6 +++++-
 .../test-legalize-erased-op-with-uses.mlir    | 21 ++++++++++++++++++-
 2 files changed, 25 insertions(+), 2 deletions(-)

diff --git a/mlir/lib/Dialect/SPIRV/IR/SPIRVOps.cpp b/mlir/lib/Dialect/SPIRV/IR/SPIRVOps.cpp
index 99bc3913c56c6..6bd91e7dfd8df 100644
--- a/mlir/lib/Dialect/SPIRV/IR/SPIRVOps.cpp
+++ b/mlir/lib/Dialect/SPIRV/IR/SPIRVOps.cpp
@@ -1226,7 +1226,11 @@ LogicalResult spirv::FuncOp::verifyBody() {
                    "returns 1 value but enclosing function requires ")
                << fnType.getNumResults() << " results";
 
-      auto retOperandType = retOp.getValue().getType();
+      Value retOperand = retOp.getValue();
+      if (!retOperand)
+        return retOp.emitOpError("return value is missing");
+
+      auto retOperandType = retOperand.getType();
       auto fnResultType = fnType.getResult(0);
       if (retOperandType != fnResultType)
         return retOp.emitOpError(" return value's type (")
diff --git a/mlir/test/Transforms/test-legalize-erased-op-with-uses.mlir b/mlir/test/Transforms/test-legalize-erased-op-with-uses.mlir
index 031442b0ee2da..829ff2f183e53 100644
--- a/mlir/test/Transforms/test-legalize-erased-op-with-uses.mlir
+++ b/mlir/test/Transforms/test-legalize-erased-op-with-uses.mlir
@@ -1,4 +1,4 @@
-// RUN: mlir-opt %s -test-legalize-unknown-root-patterns -verify-diagnostics
+// RUN: mlir-opt %s -test-legalize-unknown-root-patterns -split-input-file -verify-diagnostics
 
 // Test that an error is emitted when an operation is marked as "erased", but
 // has users that live across the conversion.
@@ -8,3 +8,22 @@ func.func @remove_all_ops(%arg0: i32) -> i32 {
   // expected-note at below {{see existing live user here}}
   return %0 : i32
 }
+
+// -----
+
+// Test that diagnostics can print a live user under an op that is not
+// verifiable while the conversion is in progress.
+module {
+  spirv.func @remove_test_ops() -> i32 "None" {
+    %cst1_i32 = spirv.Constant 1 : i32
+    // expected-error at below {{failed to legalize unresolved materialization from () to ('i32') that remained live after conversion}}
+    %0 = test.with_bounds {smax = 0 : si32, smin = 0 : si32, umax = 0 : i32, umin = 0 : ui32} : i32
+    %1 = builtin.unrealized_conversion_cast %cst1_i32 : i32 to i32
+    // expected-note at below {{see existing live user here}}
+    %2 = spirv.IAdd %0, %1 : i32
+    %3 = builtin.unrealized_conversion_cast %2 : i32 to i32
+    %4 = test.reflect_bounds %3 : i32
+    %5 = builtin.unrealized_conversion_cast %4 : i32 to i32
+    spirv.ReturnValue %5 : i32
+  }
+}