[Mlir-commits] [mlir] [mlir][vector] Make CompressstoreOp + ExpandloadOp support scalable vectors (PR #210288)

[Andrzej Warzyński]

banach-space wrote:

> Great catch on this PR. Thanks so much. Overall, LGTM :D
> 
> I'll have some minor comments, and here's a concern of mine. Currently, the verifiers are checking the equality between shapes:
> 
> https://github.com/llvm/llvm-project/blob/ccd0e982a02fa3be39a98dd98ea6cc1ccaf24d13/mlir/lib/Dialect/Vector/IR/VectorOps.cpp#L6710-L6711
> 
> 
> https://github.com/llvm/llvm-project/blob/ccd0e982a02fa3be39a98dd98ea6cc1ccaf24d13/mlir/lib/Dialect/Vector/IR/VectorOps.cpp#L6656-L6657
> 
> 
> Should we take into account the scalable dims via `getScalableDims()` or something?

Updated, see https://github.com/llvm/llvm-project/pull/210288/changes/ced689efcae970392f8c8b1da697dc8ae351d352

https://github.com/llvm/llvm-project/pull/210288