[Mlir-commits] [llvm] [mlir] [DebugInfo] Add symbolic branches to DIExpression (PR #210850)

[Aman LaChapelle]

================
@@ -7181,6 +7182,19 @@ void Verifier::visit(DbgVariableRecord &DVR) {
           F);
   visitMDNode(*DVR.getExpression(), AreDebugLocsAllowed::No);
 
+  // A DIArgList can have a valid branch expression which doesn't use
+  // DW_OP_LLVM_arg, so check the record as well.
+  if (DVR.hasArgList() && DVR.getExpression()->isValid()) {
+    bool HasControlFlow = llvm::any_of(
+        DVR.getExpression()->expr_ops(), [](DIExpression::ExprOperand Op) {
----------------
bzcheeseman wrote:

Do these checks belong as methods on DbgVariableRecord? You have another example above (somewhere) of having to compute some properties like these that might be better suited to methods

https://github.com/llvm/llvm-project/pull/210850