[Mlir-commits] [mlir] [mlir] Avoid verifying live user in conversion diagnostic (PR #210566)

[Matthias Springer]

================
@@ -3391,8 +3391,10 @@ legalizeUnresolvedMaterialization(RewriterBase &rewriter,
                             << inputOperands.getTypes() << ") to ("
                             << op.getResultTypes()
                             << ") that remained live after conversion";
-  diag.attachNote(op->getUsers().begin()->getLoc())
-      << "see existing live user here: " << *op->getUsers().begin();
+  Operation *liveUser = *op->getUsers().begin();
+  diag.attachNote(liveUser->getLoc())
+      << "see existing live user here: "
+      << OpWithFlags(liveUser, OpPrintingFlags().assumeVerified());
----------------
matthias-springer wrote:

This is still problematic. Potentially invalid IR should be printed in the generic form.

https://github.com/llvm/llvm-project/pull/210566