[Mlir-commits] [mlir] [mlir][vector] Make CompressstoreOp + ExpandloadOp support scalable vectors (PR #210288)

[Federico Bruzzone]

https://github.com/FedericoBruzzone commented:

Hi Andrzej! Great catch on this PR. Thanks so much.
Overall, LGTM :D

I'll have some minor comments, and here's a concern of mine.
Currently, the verifiers are checking the equality between shapes:
https://github.com/llvm/llvm-project/blob/ccd0e982a02fa3be39a98dd98ea6cc1ccaf24d13/mlir/lib/Dialect/Vector/IR/VectorOps.cpp#L6710-L6711
https://github.com/llvm/llvm-project/blob/ccd0e982a02fa3be39a98dd98ea6cc1ccaf24d13/mlir/lib/Dialect/Vector/IR/VectorOps.cpp#L6656-L6657
Should we take into account the scalable dims via `getScalableDims()` or something?

https://github.com/llvm/llvm-project/pull/210288