[Mlir-commits] [mlir] [NFC][OpenACC] fix doc formatting for reduction ops (PR #209739)
Scott Manley
llvmlistbot at llvm.org
Wed Jul 15 04:56:37 PDT 2026
https://github.com/rscottmanley created https://github.com/llvm/llvm-project/pull/209739
Was not printing correctly due to the matching `$`
>From 232be9cd7502176fb8fb6c1264e583adbb4a2d4b Mon Sep 17 00:00:00 2001
From: Scott Manley <scmanley at nvidia.com>
Date: Wed, 15 Jul 2026 04:54:21 -0700
Subject: [PATCH] [NFC][OpenACC] fix doc formatting for reduction ops
Was not printing correctly due to the matching `$`
---
mlir/include/mlir/Dialect/OpenACC/OpenACCCGOps.td | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/mlir/include/mlir/Dialect/OpenACC/OpenACCCGOps.td b/mlir/include/mlir/Dialect/OpenACC/OpenACCCGOps.td
index cd64fba564a56..53adb91fc2983 100644
--- a/mlir/include/mlir/Dialect/OpenACC/OpenACCCGOps.td
+++ b/mlir/include/mlir/Dialect/OpenACC/OpenACCCGOps.td
@@ -42,8 +42,8 @@ def OpenACC_ReductionInitOp
contains the recipe's init code and must yield a single value (the private
reduction storage) via `acc.yield`.
- The var operand is the original/shared reduction variable. The
- reduction_operator specifies the reduction kind (e.g. add, mul).
+ The `var` operand is the original/shared reduction variable. The
+ `reduction_operator` specifies the reduction kind (e.g. add, mul).
}];
let arguments = (ins OpenACC_AnyPointerOrMappableType:$var,
OpenACC_ReductionOperatorAttr:$reductionOperator);
@@ -74,8 +74,8 @@ def OpenACC_ReductionCombineRegionOp
value(s) in the original/shared reduction variable. The region is
terminated by `acc.yield` with no operands.
- The destVar operand is the original/shared reduction variable.
- The srcVar operand is typically the result of acc.reduction_init.
+ The `destVar` operand is the original/shared reduction variable.
+ The `srcVar` operand is typically the result of acc.reduction_init.
}];
let arguments = (ins OpenACC_AnyPointerOrMappableType:$destVar,
OpenACC_AnyPointerOrMappableType:$srcVar);
@@ -113,11 +113,11 @@ def OpenACC_ReductionCombineOp: OpenACC_Op<"reduction_combine",
memref.store %combine, %dest[] : memref<i32>
```
- The $destMemref operand is a "pointer" to the original reduction
- variable (typically shared). The $srcMemref operand is a "pointer"
+ The `destMemref` operand is a "pointer" to the original reduction
+ variable (typically shared). The `srcMemref` operand is a "pointer"
to the partial sum of the reduction (typically private).
- The $kind is the OpenACC reduction operator that determines how to
+ The `kind` is the OpenACC reduction operator that determines how to
accumulate the two values.
}];
More information about the Mlir-commits
mailing list