[Mlir-commits] [mlir] [mlir][vector] Extend `combineContractAndBroadcast` to accept `vector.shape_cast` (PR #208752)

[Diego Caballero]

================
@@ -6787,6 +6759,15 @@ LogicalResult ShapeCastOp::verify() {
   return success();
 }
 
+bool ShapeCastOp::isBroadcastLike() {
+  auto srcType = getSourceVectorType();
+  auto resType = getResultVectorType();
+
+  std::pair<VectorDim, VectorDim> mismatchingDims;
+  return isBroadcastableTo(srcType, resType, &mismatchingDims) ==
----------------
dcaballe wrote:

SG. I think what @Groverkss mentioned goes along this line but in the opposite direction and it summarizes my overall concern: I'm not sure we want to tie this up to broadcast semantics specifically. We may want to build something a bit more flexible: any unit dims, unit-dim transposes, etc.

https://github.com/llvm/llvm-project/pull/208752