[Mlir-commits] [mlir] [mlir][tosa] fallback unknown type (PR #205873)

[Luke Hutton]

================
@@ -1500,6 +1504,38 @@ bool TosaValidation::isValidElementType(Type type, const bool allowUnsigned) {
   return false;
 }
 
+LogicalResult TosaValidation::validateElementType(Operation *op, Type elementTy,
----------------
lhutton1 wrote:

nit: I think it would be better to rewrite `isValidElementType` rather than introduce this additional wrapper function. That is, `isValidElementType` should return a LogicalResult. Though once we do that, it would be good to rename `isValidElementType` -> `validateValidElementType`

https://github.com/llvm/llvm-project/pull/205873