[Mlir-commits] [mlir] [mlir][xegpu] Add support for 1D SLM case in vector-to-xepgu (PR #208276)

[Nishant Patel]

================
@@ -560,10 +560,10 @@ struct TransferReadLowering : public OpRewritePattern<vector::TransferReadOp> {
     bool isSharedMemory = xegpu::XeGPUDialect::isSharedMemory(readMemTy);
     // Handle the SLM case.
     if (isSharedMemory) {
-      // If the memref is SLM only support 2D case for now.
-      if (loadedVecTy.getRank() != 2)
+      // load_matrix supports 1D and 2D loads from SLM.
+      if (loadedVecTy.getRank() != 1 && loadedVecTy.getRank() != 2)
----------------
nbpatel wrote:

why not just check rank > 2? can scalars sneak in here?

https://github.com/llvm/llvm-project/pull/208276