[Mlir-commits] [mlir] [mlir] Add missing materialization function diag for dialect convertion (PR #207689)

[lonely eagle]

linuxlonelyeagle wrote:

> There are two cases:
> 
> 1. No type converter present
> 2. Type converter present, but unable to build a materialization
> 
> Do you want to distinguish between these two? In either case, the error message looks accurate to me. But we could add "`(no type converter specified)` to the error message for Case 1. `miss source materialization function` is not entirely accurate because there could be a materialization function that was called but did not match (i.e. produced an "empty" materialization).

Do you want to distinguish between these two? In either case, the error message looks accurate to me

Yes.

But we could add "(no type converter specified) to the error message for Case 1. miss source materialization function is not entirely accurate because there could be a materialization function that was called but did not match (i.e. produced an "empty" materialization).

May be we can say `mismatch source materialization function`, it is accurate and we can add `(no type converter specified)` to case1. This looks good.


https://github.com/llvm/llvm-project/pull/207689