[Mlir-commits] [llvm] [mlir] Number MLIR blocks; require GraphHasNodeNumbers in llvm::LoopInfoBase (PR #207617)

[Alexis Engelke]

================
@@ -524,10 +524,13 @@ raw_ostream &operator<<(raw_ostream &OS, const LoopBase<BlockT, LoopT> &Loop) {
 ///
 
 template <class BlockT, class LoopT> class LoopInfoBase {
-  // BBMap - Mapping of basic blocks to the inner most loop they occur in
-  std::conditional_t<GraphHasNodeNumbers<const BlockT *>, SmallVector<LoopT *>,
-                     DenseMap<const BlockT *, LoopT *>>
-      BBMap;
+  static_assert(GraphHasNodeNumbers<const BlockT *>,
+                "LoopInfo requires GraphTraits<BlockT *>::getNumber (see "
+                "GraphHasNodeNumbers)");
----------------
aengelke wrote:

Can we separate this? Bolt also needs changes, and I'd prefer PR1 MLIR, PR2 Bolt, PR3 LoopInfo cleanup.

https://github.com/llvm/llvm-project/pull/207617