[Mlir-commits] [mlir] Use reportFatalInternalError in DialectConversion (PR #178612)

[Mehdi Amini]

joker-eph wrote:

> So far we've been using report_fatal_error for consistency checks that are caused by user errors (users being, users of the dialect conversion framework, not compiler end users).
> So these are not entirely internal consistency checks (we use asserts for those).

IMO they really are like assert that we want enabled in production, I don't use them differently in MLIR.

https://github.com/llvm/llvm-project/pull/178612