[Mlir-commits] [mlir] Use reportFatalInternalError in DialectConversion (PR #178612)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Thu Jan 29 00:25:15 PST 2026
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- mlir/lib/Transforms/Utils/DialectConversion.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/mlir/lib/Transforms/Utils/DialectConversion.cpp b/mlir/lib/Transforms/Utils/DialectConversion.cpp
index f24603357..c5facc32e 100644
--- a/mlir/lib/Transforms/Utils/DialectConversion.cpp
+++ b/mlir/lib/Transforms/Utils/DialectConversion.cpp
@@ -2713,10 +2713,10 @@ reportNewIrLegalizationFatalError(const Pattern &pattern,
auto modifiedOpNames = llvm::map_range(
modifiedOps, [](Operation *op) { return op->getName().getStringRef(); });
llvm::reportFatalInternalError("pattern '" + pattern.getDebugName() +
- "' produced IR that could not be legalized. " +
- "new ops: {" + llvm::join(newOpNames, ", ") + "}, " +
- "modified ops: {" +
- llvm::join(modifiedOpNames, ", ") + "}");
+ "' produced IR that could not be legalized. " +
+ "new ops: {" + llvm::join(newOpNames, ", ") +
+ "}, " + "modified ops: {" +
+ llvm::join(modifiedOpNames, ", ") + "}");
}
LogicalResult OperationLegalizer::legalizeWithPattern(Operation *op) {
@@ -2773,8 +2773,9 @@ LogicalResult OperationLegalizer::legalizeWithPattern(Operation *op) {
if (checkOp && topLevelFingerPrint) {
OperationFingerPrint fingerPrintAfterPattern(checkOp);
if (fingerPrintAfterPattern != *topLevelFingerPrint)
- llvm::reportFatalInternalError("pattern '" + pattern.getDebugName() +
- "' returned failure but IR did change");
+ llvm::reportFatalInternalError(
+ "pattern '" + pattern.getDebugName() +
+ "' returned failure but IR did change");
}
#endif // MLIR_ENABLE_EXPENSIVE_PATTERN_API_CHECKS
}
@@ -2871,8 +2872,9 @@ LogicalResult OperationLegalizer::legalizePatternResult(
return hasRewrite<ModifyOperationRewrite>(newRewrites, op);
};
if (!replacedRoot() && !updatedRootInPlace())
- llvm::reportFatalInternalError("expected pattern to replace the root operation "
- "or modify it in place");
+ llvm::reportFatalInternalError(
+ "expected pattern to replace the root operation "
+ "or modify it in place");
}
#endif // MLIR_ENABLE_EXPENSIVE_PATTERN_API_CHECKS
``````````
</details>
https://github.com/llvm/llvm-project/pull/178612
More information about the Mlir-commits
mailing list