[Mlir-commits] [mlir] [MLIR][NVVM] Return ISA compiler log via ObjectAttr properties (PR #176697)

[Mehdi Amini]

================
@@ -747,6 +771,11 @@ NVVMTargetAttrImpl::serializeToObject(Attribute attribute, Operation *module,
   if (isaToBinaryTimeInMs.has_value())
     module->setAttr("ISAToBinaryTimeInMs",
                     builder.getI64IntegerAttr(*isaToBinaryTimeInMs));
+  StringRef isaCompilerLog = serializer.getISACompilerLog();
+  if (!isaCompilerLog.empty())
+    module->setDiscardableAttr("ISACompilerLog",
+                               builder.getStringAttr(isaCompilerLog));
----------------
joker-eph wrote:

I'm still a bit concerned about this use of a discardable attribute here: can't there be multiple target for the same module? There is a risk of mix-ups here.
Can we return the log through the API instead somehow?

https://github.com/llvm/llvm-project/pull/176697