[Mlir-commits] [mlir] [mlir][dataflow] Drop the firstIndex argument of visitNonControlFlowArguments (PR #175210)

[Matthias Springer]

================
@@ -156,7 +156,8 @@ void IntegerRangeAnalysis::visitNonControlFlowArguments(
         return;
 
       LDBG() << "Inferred range " << attrs;
-      IntegerValueRangeLattice *lattice = argLattices[arg.getArgNumber()];
+      IntegerValueRangeLattice *lattice =
+          nonSuccessorInputLattices[arg.getArgNumber()];
----------------
matthias-springer wrote:

I'm still wondering if this is incorrect, if we come here from `AbstractSparseForwardDataFlowAnalysis::visitRegionSuccessors`. I expected the following:

```c++
auto it = llvm::find(successor.getSuccessor()->getArguments(), arg);
unsigned nonSuccessorInputIdx = std::distance(successor.getSuccessor()->getArguments().begin(), it);
IntegerValueRangeLattice *lattice =
          nonSuccessorInputLattices[nonSuccessorInputIdx];
```


https://github.com/llvm/llvm-project/pull/175210