[Mlir-commits] [mlir] [mlir][dataflow] Drop the firstIndex argument of visitNonControlFlowArguments (PR #175210)

[Matthias Springer]

================
@@ -215,8 +215,8 @@ class AbstractSparseForwardDataFlowAnalysis : public DataFlowAnalysis {
   /// of loops).
   virtual void visitNonControlFlowArgumentsImpl(
       Operation *op, const RegionSuccessor &successor,
-      ValueRange successorInputs, ArrayRef<AbstractSparseLattice *> argLattices,
-      unsigned firstIndex) = 0;
+      ValueRange nonSuccessorInputs,
+      ArrayRef<AbstractSparseLattice *> nonSuccessorInputLattices) = 0;
----------------
matthias-springer wrote:

> When the op is not a RegionBranchOp, we pass in all lattices.

OK, that makes sense. When the op is not a `RegionBranchOpInterfaceOp`, all block arguments / op results are non-successor-inputs.

https://github.com/llvm/llvm-project/pull/175210