[Mlir-commits] [clang] [mlir] [CIR] Implement 'noreturn' attribute for functions/calls. (PR #177978)

[Tobias Gysi]

https://github.com/gysit commented:

Direction looks good to me. 

I believe the actual attribute translation in the import is missing and some tests would be good.

The test for the will return attribute are here:
- `mlir/tests/LLVMIR/Import/function-attributes.ll` (for function import)
- `mlir/tests/LLVMIR/Import/instructions-attributes.ll` (for the calls import)
- `mlir/tests/Target/LLVMIR/llvmir.mlir (for functions and call export)
- `mlir/test/Dialect/LLVMIR/func.mlir` (function rountrip)
- `mlir/test/Dialect/LLVMIR/roundtrip.mlir` (call rountrip)

It is unfortunately very distributed...



https://github.com/llvm/llvm-project/pull/177978